diff options
| author | Sven Herzberg <herzberg.sven@googlemail.com> | 2012-07-03 18:10:32 +0200 |
|---|---|---|
| committer | Sven Herzberg <herzberg.sven@googlemail.com> | 2012-07-03 18:12:07 +0200 |
| commit | fd6b3c6de21724f8dff524d602ef88c8b3128da7 (patch) | |
| tree | 4b1739525c2fc1243511e635191f24f4a966dfb7 | |
| parent | afc4d6e25ed75379fd70eb4d984582d9dfc21056 (diff) | |
| download | nyancat-fd6b3c6de21724f8dff524d602ef88c8b3128da7.tar.gz | |
do not hardcode sizes
This patch will fix the following warning I received from gcc:
> nyancat.c: In function ‘main’:
> nyancat.c:497: warning: comparison is always true due to limited range of data type
* src/nyancat.c: adjust the size of the array and update the references
to its size
| -rw-r--r-- | src/nyancat.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/nyancat.c b/src/nyancat.c index 234ff10..fbb3c6e 100644 --- a/src/nyancat.c +++ b/src/nyancat.c @@ -483,7 +483,7 @@ int main(int argc, char ** argv) { /* Begin Extended Option Mode */ sb_mode = 1; sb_len = 0; - memset(sb, 0, 1024); + memset(sb, 0, sizeof(sb)); break; case IAC: /* IAC IAC? That's probably not right. */ @@ -494,7 +494,7 @@ int main(int argc, char ** argv) { } } else if (sb_mode) { /* Extended Option Mode -> Accept character */ - if (sb_len < 1023) { + if (sb_len < sizeof(sb) - 1) { /* Append this character to the SB string, * but only if it doesn't put us over * our limit; honestly, we shouldn't hit |