From fd6b3c6de21724f8dff524d602ef88c8b3128da7 Mon Sep 17 00:00:00 2001
From: Sven Herzberg <herzberg.sven@googlemail.com>
Date: Tue, 3 Jul 2012 18:10:32 +0200
Subject: do not hardcode sizes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This patch will fix the following warning I received from gcc:
> nyancat.c: In function ‘main’:
> nyancat.c:497: warning: comparison is always true due to limited range of data type
* src/nyancat.c: adjust the size of the array and update the references
to its size
---
src/nyancat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
(limited to 'src')
diff --git a/src/nyancat.c b/src/nyancat.c
index 234ff10..fbb3c6e 100644
--- a/src/nyancat.c
+++ b/src/nyancat.c
@@ -483,7 +483,7 @@ int main(int argc, char ** argv) {
/* Begin Extended Option Mode */
sb_mode = 1;
sb_len = 0;
- memset(sb, 0, 1024);
+ memset(sb, 0, sizeof(sb));
break;
case IAC:
/* IAC IAC? That's probably not right. */
@@ -494,7 +494,7 @@ int main(int argc, char ** argv) {
}
} else if (sb_mode) {
/* Extended Option Mode -> Accept character */
- if (sb_len < 1023) {
+ if (sb_len < sizeof(sb) - 1) {
/* Append this character to the SB string,
* but only if it doesn't put us over
* our limit; honestly, we shouldn't hit
--
cgit v1.2.3